Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: cache archive entry checksums #1004

Merged
merged 18 commits into from
Mar 21, 2024
Merged

Conversation

emmercm
Copy link
Owner

@emmercm emmercm commented Mar 15, 2024

RE: #937

@emmercm emmercm self-assigned this Mar 15, 2024
Copy link

github-actions bot commented Mar 15, 2024

🧪 Branch testing instructions

This pull request can be tested locally with the following command:

npm exec --yes -- "github:emmercm/igir#emmercm/file-factory-cache" [commands..] [options]

Comment generated by the Pull Request Commenter workflow.

@emmercm emmercm changed the title Refactor: FileFactory cache Feature: cache archive entry checksums Mar 19, 2024
@emmercm emmercm marked this pull request as ready for review March 21, 2024 03:04
@emmercm emmercm enabled auto-merge (squash) March 21, 2024 03:04
Copy link

codecov bot commented Mar 21, 2024

Codecov Report

Attention: Patch coverage is 83.87097% with 20 lines in your changes are missing coverage. Please review.

Project coverage is 93.38%. Comparing base (307770c) to head (37c8d05).

Files Patch % Lines
src/types/cache.ts 71.05% 11 Missing ⚠️
src/types/files/file.ts 64.28% 5 Missing ⚠️
src/types/files/fileCache.ts 94.23% 3 Missing ⚠️
src/modules/datScanner.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1004      +/-   ##
==========================================
- Coverage   93.57%   93.38%   -0.19%     
==========================================
  Files          91       92       +1     
  Lines        5773     5883     +110     
  Branches     1344     1388      +44     
==========================================
+ Hits         5402     5494      +92     
- Misses        352      370      +18     
  Partials       19       19              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emmercm emmercm merged commit af610f7 into main Mar 21, 2024
52 of 53 checks passed
@emmercm emmercm deleted the emmercm/file-factory-cache branch March 21, 2024 03:11
Copy link

🔒 Inactive pull request lock

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

Comment generated by the GitHub Lock Issues workflow.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant