Skip to content

Commit

Permalink
Add convention plugins to version catalog (droidconKE#223)
Browse files Browse the repository at this point in the history
* Add convention plugins to version catalogs

* Upgrade gradle to 8.4

From gradle 8.1+ plugin alias declarations are no longer highlighted as
an error.
  • Loading branch information
etonotieno authored Oct 15, 2023
1 parent 70982d4 commit cf411ac
Show file tree
Hide file tree
Showing 12 changed files with 203 additions and 132 deletions.
6 changes: 3 additions & 3 deletions app/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,9 @@
* limitations under the License.
*/
plugins {
id("droidconke.android.application")
id("droidconke.android.hilt")
id("droidconke.android.application.firebase")
alias(libs.plugins.droidconke.android.application)
alias(libs.plugins.droidconke.android.hilt)
alias(libs.plugins.droidconke.android.application.firebase)
}

android {
Expand Down
4 changes: 2 additions & 2 deletions chai/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@
* limitations under the License.
*/
plugins {
id("droidconke.android.library")
id("droidconke.android.library.compose")
alias(libs.plugins.droidconke.android.library)
alias(libs.plugins.droidconke.android.library.compose)
}

android {
Expand Down
6 changes: 3 additions & 3 deletions data/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,9 @@
* limitations under the License.
*/
plugins {
id("droidconke.android.library")
id("droidconke.android.hilt")
id("droidconke.android.library.firebase")
alias(libs.plugins.droidconke.android.library)
alias(libs.plugins.droidconke.android.hilt)
alias(libs.plugins.droidconke.android.library.firebase)
kotlin("plugin.serialization")
}

Expand Down
8 changes: 4 additions & 4 deletions datasource/local/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,10 @@
* limitations under the License.
*/
plugins {
id("droidconke.android.library")
id("droidconke.android.room")
id("droidconke.android.hilt")
id("droidconke.android.library.firebase")
alias(libs.plugins.droidconke.android.library)
alias(libs.plugins.droidconke.android.room)
alias(libs.plugins.droidconke.android.hilt)
alias(libs.plugins.droidconke.android.library.firebase)
}

android {
Expand Down
6 changes: 3 additions & 3 deletions datasource/remote/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,9 @@
* limitations under the License.
*/
plugins {
id("droidconke.android.library")
id("droidconke.android.hilt")
id("droidconke.android.library.firebase")
alias(libs.plugins.droidconke.android.library)
alias(libs.plugins.droidconke.android.hilt)
alias(libs.plugins.droidconke.android.library.firebase)
kotlin("plugin.serialization")
}

Expand Down
2 changes: 1 addition & 1 deletion domain/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
* limitations under the License.
*/
plugins {
id("droidconke.android.library")
alias(libs.plugins.droidconke.android.library)
}

android {
Expand Down
9 changes: 9 additions & 0 deletions gradle/libs.versions.toml
Original file line number Diff line number Diff line change
Expand Up @@ -131,3 +131,12 @@ spotless = "com.diffplug.spotless:6.4.2"
toml-checker = "com.github.ben-manes.versions:0.42.0"
toml-updater = "nl.littlerobots.version-catalog-update:0.3.1"
ksp = { id = "com.google.devtools.ksp", version.ref = "ksp" }

# Convention plugins defined in the project
droidconke-android-library = { id = "droidconke.android.library", version = "unspecified" }
droidconke-android-room = { id = "droidconke.android.room", version = "unspecified" }
droidconke-android-hilt = { id = "droidconke.android.hilt", version = "unspecified" }
droidconke-android-library-compose = { id = "droidconke.android.library.compose", version = "unspecified" }
droidconke-android-application-firebase = { id = "droidconke.android.application.firebase", version = "unspecified" }
droidconke-android-library-firebase = { id = "droidconke.android.library.firebase", version = "unspecified" }
droidconke-android-application = { id = "droidconke.android.application", version = "unspecified" }
Binary file modified gradle/wrapper/gradle-wrapper.jar
Binary file not shown.
4 changes: 2 additions & 2 deletions gradle/wrapper/gradle-wrapper.properties
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#Sat Feb 11 12:19:01 EAT 2023
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-8.0-bin.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-8.4-bin.zip
networkTimeout=10000
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists
Loading

0 comments on commit cf411ac

Please sign in to comment.