implementation of add_request_headers and add_response_headers as obj…

[ysaakpr]

Description

This change is to support the map based configuration for add_request_headers and add_response_headers, to support the advanced configuration of the 'append' flag in the virtual host config.

Related Issues

List related issues.

Testing

Haven't tested, only done linting

Todos

• Tests
• Documentation

Other

• If this is a documentation change, please open the pull request at https://github.com/datawire/ambassador-docs instead.
• Code changes should occur against master.

[ysaakpr]

@kflynn Can you tell me why the checks are failed, doesn't seems to be because of my changes, And please review the changes and let me know what all to done to have a merge.

[kflynn]

Code looks pretty reasonable, thanks!

We already have tests in t_optiontests.py for these options; if you can extend those, I'll see if I can't figure out a simple way for you to run them in minikube or the like...

[kflynn]

(You should also merge master into your branch -- that'll trigger another CI run, and in the process clean up some stuff about CI...)

[ysaakpr]

@kflynn merged from master to my fork, still having a similar error,
Checking 235 url requirements... 2 not ready (http://plain.plain-namespace/ambassador/v0/check_ready: Get http://plain.plain-namespace/ambassador/v0/check_ready: net/http: request canceled (Client.Timeout exceeded while awaiting headers)) sleeping 10s...

[ysaakpr]

Docs PR is also raised against master datawire/ambassador-docs#42

[concaf]

Hey, thanks for the great work 🎉

I have left some comments, one that asks to make the documentation a bit clearer, and another that asks for testing the behavior more than it currently does.

Also, I'm curious on how did you manually test this?