Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS class "loader" overlaps #305

Closed
coder-Rit opened this issue Jan 19, 2024 · 1 comment · Fixed by #315
Closed

CSS class "loader" overlaps #305

coder-Rit opened this issue Jan 19, 2024 · 1 comment · Fixed by #315

Comments

@coder-Rit
Copy link

Describe the feature / bug 📝:

Sonner's CSS class "loader" overlaps with the user's custom CSS className "loader".
N/A

Steps to reproduce the bug 🔁:

  1. Create a span element that has the className "loader".
  2. Add Sonner code in that JSX element.
  3. observer the behavior of the span element's "loader" class.

adds the property "display: absolute"
Screenshot (1069)

change the name of class to "loaderPersonal"->works fine

Screenshot (1070)

@jschoder
Copy link
Contributor

@coder-Rit The fix in the code was pretty straight forward. It was using the general .loaderclassName which will break other code using the same className. I don't see a way to fix this outside the project and the only workaround is not to use the general .loaderclass, which probably a good strategy anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants