-
-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Close button isn't easily discoverable on hover #224
Comments
I can resolve that issue if it wasnt assigned yet, I will add that as custom option for toast 😉 |
Nice! Let's make it optional and disabled by default @andrewbarnesweb. |
Not sure I follow 🙂. The close button is already optional? Just when it's passed in you can't see it, unless you hover - so I raised a PR for having the close button visible if passed. Let me know what your expectation is here and I'll update the PR 👍🏻 |
@andrewbarnesweb @emilkowalski is it possible to change the position of the closeButton? |
@emilkowalski is there any way to change the position of the close button without having to make a full blown custom toast? |
The close button is discoverable without the hover effect now. To change its position you can target |
The close button is only visible on hover, which isn't easily discoverable for users. They may well not know the functionality exists if they never hover over the component.
Further to this, on touch devices, there is no obvious way to trigger the functionality - I thought it was a bug when trying on an iPhone - as there's no icon to hit.
The text was updated successfully, but these errors were encountered: