Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

glow painter every where #852

Closed
wants to merge 35 commits into from
Closed

glow painter every where #852

wants to merge 35 commits into from

Conversation

KentaTheBugMaker
Copy link
Contributor

@KentaTheBugMaker KentaTheBugMaker commented Oct 29, 2021

egui_web webgl1 and webgl2 use almost same code .
egui_glow painter use very similar code to web painters.
so i port PostProcess to egui_glow.
and create new crate that only contains painter and context create utility.
Current status

  • OpenGL 2.1 or above(same as glow and glium)
  • WebGL2(same as egui_web)
  • WebGL1(same as egui_web)
  • WebGL1 + sRGB(same as egui_web)

@AlexApps99 AlexApps99 mentioned this pull request Oct 29, 2021
@KentaTheBugMaker
Copy link
Contributor Author

eliminated VAO by emulating VAO in painter.

@KentaTheBugMaker KentaTheBugMaker marked this pull request as ready for review October 30, 2021 06:50
@emilk
Copy link
Owner

emilk commented Nov 1, 2021

What is the motivation for adding egui_glow_painter as a separate crate? If you don't want the winit-stuff of egui_glow, perhaps we can hide that behind a feature-flag instead so we don't get too many crates?

@KentaTheBugMaker
Copy link
Contributor Author

OK I will make more acceptable new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants