Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to wgpu 22.0.0 #4847

Merged
merged 6 commits into from
Jul 19, 2024
Merged

upgrade to wgpu 22.0.0 #4847

merged 6 commits into from
Jul 19, 2024

Conversation

KeKsBoTer
Copy link
Contributor

@KeKsBoTer KeKsBoTer commented Jul 18, 2024

@KeKsBoTer KeKsBoTer requested a review from Wumpf as a code owner July 18, 2024 20:37
@Wumpf
Copy link
Collaborator

Wumpf commented Jul 19, 2024

Now that lifetimes on passes are more relaxed there's probably room for some follow-ups we can do to make the render callback system easier to use. Needs looking into & experimentation!
(meant to do that before wgpu 22 goes out as an exploration of wgpu's changes there, but things rarely go as planned :))

@Wumpf Wumpf merged commit 56df31a into emilk:master Jul 19, 2024
19 of 20 checks passed
@John-Nagle
Copy link

It looks like wgpu-egui was changed without changing its version:

56df31a

So that can't be pushed to crates.io, where the version must change if the content does.
So egui-wgpu at crates.io 0.28.1, last updated 14 days ago, is out of sync with Github master. I think.

@Wumpf
Copy link
Collaborator

Wumpf commented Jul 19, 2024

nothing unusual there: egui & eframe also have changed since 0.28.1. There's a few repos that immediately change the version after release because technically the first change after a release if for an unreleased version, but this repo is not one of them.
There's going to be a 0.29.0 at some point published to crates.io containing that change, until then applications that want it will have to point to a commit hash instead

@John-Nagle
Copy link

OK. So there's a workaround on the egui side.

I'm currently stuck due to wgpu-profiler problems. That can't even be built against current WGPU without another WGPU fix. Looks like a WGPU 22.1.x will be needed.

486c pushed a commit to 486c/egui that referenced this pull request Oct 9, 2024
hacknus pushed a commit to hacknus/egui that referenced this pull request Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WGPU just jumped to version 22.0.0. egui-wgpu now out of sync with wgpu
4 participants