Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure contents of a panel don't overflow #4676

Merged
merged 1 commit into from
Jun 19, 2024
Merged

Conversation

emilk
Copy link
Owner

@emilk emilk commented Jun 19, 2024

@emilk emilk added bug Something is broken egui labels Jun 19, 2024
@emilk emilk changed the title Make sure contents of a panel don't overflow the panel Make sure contents of a panel don't overflow Jun 19, 2024
@emilk emilk merged commit d23742c into master Jun 19, 2024
37 checks passed
@emilk emilk deleted the emilk/fix-panel-overflow branch June 19, 2024 08:41
emilk added a commit to rerun-io/rerun that referenced this pull request Jun 19, 2024
### What
* Update to latest egui, including
emilk/egui#4676 (among other things)
* Removes workaround for #6227
added in #6255
* Closes #6256

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using examples from latest `main` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/6593?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/6593?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG
* [x] If applicable, add a new check to the [release
checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)!

- [PR Build Summary](https://build.rerun.io/pr/6593)
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)

To run all checks from `main`, comment on the PR with `@rerun-bot
full-check`.
hacknus pushed a commit to hacknus/egui that referenced this pull request Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is broken egui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SidePanel frame leaks into BottomPanel
1 participant