Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass ScreenDescriptor to egui_wgpu::CallbackTrait::prepare #3960

Merged
merged 4 commits into from
Feb 5, 2024
Merged

Pass ScreenDescriptor to egui_wgpu::CallbackTrait::prepare #3960

merged 4 commits into from
Feb 5, 2024

Conversation

StratusFearMe21
Copy link
Contributor

@StratusFearMe21 StratusFearMe21 commented Feb 4, 2024 •
edited
Loading

glyphon requires the screen resolution during the prepare stage, and passing that to the callback's prepare function seems pretty trivial.

emilk
emilk approved these changes Feb 5, 2024
View reviewed changes
Copy link
Owner

@emilk emilk left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but one small nit: I think the screen descriptor should come before the mutable parameters to give the parameters a more logical order

@emilk emilk added the egui-wgpu label Feb 5, 2024
@emilk emilk merged commit 7a6d80c into emilk:master Feb 5, 2024
19 of 20 checks passed
@StratusFearMe21 StratusFearMe21 deleted the wgpu-callback-pass-screen-descriptor branch February 5, 2024 11:54
hacknus pushed a commit to hacknus/egui that referenced this pull request Oct 30, 2024
@StratusFearMe21 @emilk @hacknus
Pass ScreenDescriptor to egui_wgpu::CallbackTrait::prepare (emilk…
9334ab5 
…#3960)

<!--
Please read the "Making a PR" section of
[`CONTRIBUTING.md`](https://github.com/emilk/egui/blob/master/CONTRIBUTING.md)
before opening a Pull Request!

* Keep your PR:s small and focused.
* If applicable, add a screenshot or gif.
* If it is a non-trivial addition, consider adding a demo for it to
`egui_demo_lib`, or a new example.
* Do NOT open PR:s from your `master` branch, as that makes it hard for
maintainers to add commits to your PR.
* Remember to run `cargo fmt` and `cargo cranky`.
* Open the PR as a draft until you have self-reviewed it and run
`./scripts/check.sh`.
* When you have addressed a PR comment, mark it as resolved.

Please be patient! I will review your PR, but my time is limited!
-->

`glyphon` requires the screen resolution during the `prepare` stage, and
passing that to the callback's `prepare` function seems pretty trivial.

---------

Co-authored-by: Emil Ernerfeldt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilk emilk emilk approved these changes

Assignees
No one assigned
Labels
egui-wgpu
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@StratusFearMe21 @emilk