Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add @Bromeon and @EmbersArc as CODEOWNERS for egui_plot #3711

Merged
merged 1 commit into from
Dec 21, 2023

Conversation

emilk
Copy link
Owner

@emilk emilk commented Dec 18, 2023

Please take a look @Bromeon and @EmbersArc!

You have both contributed substantially to egui_plot (more than I have).
This is me inviting you to co-maintain the egui_plot crate.
If you accept, you'll get a notification when someone opens a PR touching egui_plot, and you can review and merge it as you see fit.
You can also merge your own egui_plot PRs without waiting on me to review them.

@emilk emilk added the egui_plot Related to egui_plot label Dec 18, 2023
@Bromeon
Copy link
Contributor

Bromeon commented Dec 19, 2023

Hey, thanks a lot for the trust! 🙂

Full disclosure, I'm not sure how much time I can commit to PR/issue reviews at the moment, as I already maintain godot-rust and am part of Godot and SFML teams, next to a full time job 😉 On the other hand, in 2024 I plan to work on a small game project. It might be a good chance to use egui and its plots for UIs, which would allow to dogfood some of the APIs. But I don't have a timeline yet.

TLDR: Good for me if the above expectations are OK!

@EmbersArc
Copy link
Contributor

Hey, fine with me! Pretty much the same caveats apply though: Full-time job plus a game project on the side. But I'd be happy to have a look at PRs from time to time.

@emilk
Copy link
Owner Author

emilk commented Dec 21, 2023

Awesome, thanks!

And yes, of course this is a "when you find time" sort of things (same as for me 😅)

@emilk emilk merged commit e36b981 into master Dec 21, 2023
35 of 36 checks passed
@emilk emilk deleted the emilk/egui_plot-owners branch December 21, 2023 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants