Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix depth texture init with multisampling #3207

Merged
merged 1 commit into from
Aug 9, 2023
Merged

Fix depth texture init with multisampling #3207

merged 1 commit into from
Aug 9, 2023

Conversation

mauliu
Copy link
Contributor

@mauliu mauliu commented Aug 6, 2023

Closes #3200.

@emilk emilk requested a review from Wumpf August 8, 2023 19:56
@emilk emilk added the egui-wgpu label Aug 8, 2023
emilk
emilk approved these changes Aug 9, 2023
View reviewed changes
Copy link
Owner

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@Wumpf Wumpf merged commit af64193 into emilk:master Aug 9, 2023
@Wumpf Wumpf added the bug Something is broken label Aug 9, 2023
@emilk emilk changed the title fix depth texture init with multisampling Fix depth texture init with multisampling Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wumpf Wumpf Wumpf approved these changes

@emilk emilk emilk approved these changes

Assignees
No one assigned
Labels
bug Something is broken egui-wgpu
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wgpu validation error if multisampling and depth_buffer is used
3 participants
@mauliu @emilk @Wumpf