Fix text sizes being too small #2069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #2068 Before this PR, the default font, Ubuntu-Light, was ~11% smaller than it should have been, and the default monospace font, Hack, was ~14% smaller. This means that setting the font size `12` in egui would yield smaller text than using that font size in any other app. Ooops! The change is that this PR now takes into account the ttf properties `units_per_em` and `height_unscaled`. If your egui application has specified you own font sizes or text styles you will see the text in your application grow larger, unless you go in and compensate by dividing all font sizes by ~1.21 for Ubuntu-Light/Proportional and ~1.16 for Hack/Monospace, and with something else if you are using a custom font! This effects any use of `FontId`, `RichText::size`, etc. This PR changes the default `Style::text_styles` to compensate, so the default egui style should look the same before and after this PR.
emilk
added a commit
to rerun-io/rerun
that referenced
this pull request
Sep 24, 2022
Includes recent improvements to text rendering: * emilk/egui#2071 * emilk/egui#2070 * emilk/egui#2069
emilk
added a commit
to rerun-io/rerun
that referenced
this pull request
Sep 24, 2022
Includes recent improvements to text rendering: * emilk/egui#2071 * emilk/egui#2070 * emilk/egui#2069
nozwock
added a commit
to nozwock/rusty-autoclicker
that referenced
this pull request
Dec 31, 2022
MrTanoshii
pushed a commit
to MrTanoshii/rusty-autoclicker
that referenced
this pull request
Dec 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2068
Before this PR, the default font, Ubuntu-Light, was ~11% smaller than it should have been, and the default monospace font, Hack, was ~14% smaller. This means that setting the font size
12in egui would yield smaller text than using that font size in any other app. Ooops!The change is that this PR now takes into account the ttf properties
units_per_emandheight_unscaled.If your egui application has specified you own font sizes or text styles you will see the text in your application grow
larger, unless you go in and compensate by dividing all font sizes by ~1.21 for Ubuntu-Light/Proportional and ~1.16 for Hack/Monospace, and with something else if you are using a custom font! This effects any use of
FontId,RichText::size, etc.This PR changes the default
Style::text_stylesto compensate, so the default egui style should look the same before and after this PR.