Tessellate: Implement precomputed vertices for rounding #1507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before:
demo_with_tessellate__realistic
time: [328.77 us 329.22 us 329.70 us]
change: [-2.6116% -1.1978% +0.2520%] (p = 0.10 > 0.05)
No change in performance detected.
demo_no_tessellate time: [164.67 us 165.82 us 167.30 us]
demo_only_tessellate time: [159.34 us 159.85 us 160.67 us]
After:
demo_with_tessellate__realistic
time: [309.48 us 309.92 us 310.41 us]
change: [-7.1042% -5.6164% -4.0262%] (p = 0.00 < 0.05)
Performance has improved.
demo_no_tessellate time: [160.44 us 161.30 us 162.49 us]
change: [-4.5692% -2.8617% -1.3549%] (p = 0.00 < 0.05)
Performance has improved.
demo_only_tessellate time: [139.45 us 140.23 us 141.25 us]
change: [-13.637% -12.245% -10.695%] (p = 0.00 < 0.05)
Performance has improved.
Not sure this is the right path. So i didn't bother to port Path::add_point()
Also we might want to fallback to computed vertices for radii >= 20 or add
another precomputed batch.
emilk
reviewed
Apr 16, 2022
emilk
reviewed
Apr 16, 2022
emilk
reviewed
Apr 16, 2022
emilk
reviewed
Apr 19, 2022
| vec2(0.707107, -0.707107), | ||
| vec2(0.923880, -0.382683), | ||
| vec2(1.000000, 0.000000), | ||
| ], |
There was a problem hiding this comment.
Instead of having the four quadrants in separate array, we could just have all the circle vertices in circular order, and just slice into it. That way we could reuse the same vertices for circles too! It can wait for a separate PR though if you want.
emilk
reviewed
Apr 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
After:
Not sure this is the right path. So i didn't bother to port
Path::add_point()Also we might want to fallback to computed vertices for radii >= 20 or add
another precomputed batch.