Use Protonmail fork of golang.org/x/crypto #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds support for ed25519 (termed State-of-the-art by PM) private keys. SRP modulus signature verification segfaults, so I commented it out.
Hm. Would be nice to dive in the protonmail official bridge codebase and figure out how they check the SRP modulus signature. |
|
The Protonmail official bridge checks against a hardcoded public key. See: I'm updating this pull request to use that method. Works for me without segfaults. |
Closed
Code follows how the official proton-bridge is doing it.
In 93c8007, SRP signature errors were made non-fatal because many users got the following error: openpgp: unsupported feature: public key algorithm 22 This is because Protonmail started signing these messages with an EDDSA key, an algorithm which the Go OpenPGP library does not support. The switch to github.com/protonmail/crypto introduces this algorithm, so messages that haven't been tampered with should pass the verification.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ProtonMail fork of
golang.org/x/cryptoadds support for for ed25519 (termed State-of-the-art by PM) keys. These changes address the breaking changes to the API. According to ProtonMail/go-crypto#21, there are plans to eventually upstream these, so hopefully we won't have to stick with a fork for long. This library is used by the official bridge, and it is by far the most popular fork and tracks upstream nicely.Someone who doesn't get
openpgp: unsupported feature: public key algorithm 22when runninghydroxide authshould take a look if they get a segfault with the lines below and their corresponding imports uncommented.https://github.com/BertalanD/hydroxide/blob/287c9b9683e918fd0e8f7cfaf7070ac2d4408cfd/protonmail/srp.go#L27-L31
For the reference, my SRP modulus message was singed by an EDDSA key (ID
0x350585C4E9518F26) and maybe the algorithm has something to do with the segfault.Fixes #46
Fixes #53