Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when selecting should unselect #366

Merged
merged 4 commits into from
Jul 8, 2020
Merged

Error when selecting should unselect #366

merged 4 commits into from
Jul 8, 2020

Conversation

jameshoulahan
Copy link

@jameshoulahan jameshoulahan commented Jul 8, 2020

Fixes #351

(also includes a little tidyup that the linter spotted)

@codecov
Copy link

codecov bot commented Jul 8, 2020

Codecov Report

Merging #366 into master will increase coverage by 0.01%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #366      +/-   ##
==========================================
+ Coverage   68.88%   68.89%   +0.01%     
==========================================
  Files          41       41              
  Lines        3795     3797       +2     
==========================================
+ Hits         2614     2616       +2     
  Misses        882      882              
  Partials      299      299              
Impacted Files Coverage Δ
server/cmd_auth.go 79.84% <66.66%> (+0.31%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3bc38e3...5730264. Read the comment docs.

server/cmd_auth.go Outdated Show resolved Hide resolved
server/cmd_auth.go Outdated Show resolved Hide resolved
@foxcpp
Copy link
Collaborator

foxcpp commented Jul 8, 2020

Speaking of UNSELECT, perhaps #342 can help. :)

server/cmd_auth.go Outdated Show resolved Hide resolved
Copy link
Owner

@emersion emersion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution!

@emersion emersion merged commit 011063d into emersion:master Jul 8, 2020
@jameshoulahan jameshoulahan deleted the feat/err-select-should-unselect branch July 8, 2020 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed select should unselect
3 participants