This repository has been archived by the owner on Nov 7, 2023. It is now read-only.
fix: replace deprecated Masterkeys class with Masterkey.Builder #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! Thank you for this, I wasn't even aware of the deprecation you mentioned. I will review this later today, happy holidays! |
emeraldsanto
changed the title
This was referenced Jan 2, 2021
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #33 by migrating from deprecated
MasterKeysclass. Also, this PR adds android unit test to check library on different android devices (I checked on android 5 VM and it works). As well, this PR bumpsandroidx.security:security-cryptowhich has possibility to fix #31