fix(unhide accounts): #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shanejonas
commented
Oct 24, 2017
package.json
Outdated
| @@ -64,7 +64,7 @@ | |||
| "decompress-zip": "^0.3.0", | |||
| "electron-log": "^2.2.6", | |||
| "electron-store": "^1.1.0", | |||
| "emerald-js": "git+https://github.com/ethereumproject/emerald-js.git#v0.0.11", | |||
| "emerald-js": "git+https://github.com/shanejonas/emerald-js.git#feature/unhide-accounts", | |||
There was a problem hiding this comment.
[WIP] change this when emerald-js is merged
There was a problem hiding this comment.
I'v tagged emerald-js v0.0.12, it is possible to fix dependency
whilei
reviewed
Oct 25, 2017
| let showHiddenAccounts = localStorage.getItem('showHiddenAccounts'); | ||
| dispatch({ | ||
| type: ActionTypes.SET_SHOW_HIDDEN_ACCOUNTS, | ||
| show: !!showHiddenAccounts, |
whilei
approved these changes
Oct 25, 2017
Codecov Report
@@ Coverage Diff @@
## master #347 +/- ##
=========================================
+ Coverage 8.49% 8.53% +0.04%
=========================================
Files 201 201
Lines 2520 2531 +11
Branches 440 441 +1
=========================================
+ Hits 214 216 +2
- Misses 1906 1915 +9
Partials 400 400
Continue to review full report at Codecov.
|
This was referenced Aug 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on: emeraldpay/emerald-js#20