display empty txs better and send links to browser #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whilei
changed the title
solution: send tx button when there is an account, otherwise button to create account
solution: remove target='_blank'
elaineo
approved these changes
Jun 23, 2017
| Github issues page</a>. | ||
| </p> | ||
| <p> | ||
| Made with ❤️ by <strong>ETCDEV</strong> and <a target='_blank' href='https://github.com/ethereumproject/emerald-wallet/network/members'>many wonderful contributors</a>. | ||
| Made with ❤️ by <strong>ETCDEV</strong> and <a href='https://github.com/ethereumproject/emerald-wallet/network/members'>many wonderful contributors</a>. |
There was a problem hiding this comment.
how come you don't want to open in new window? (no big deal, just curious)
There was a problem hiding this comment.
electron opens blank targets for whatever reason in a new electron window instead of sending to default browser
There was a problem hiding this comment.
there may be a way to work around it by fiddling with the listener around here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rel #168
While an incremental improvement for the time being, it opens the idea of handling the bigger picture when 0accts and/or 0txs exist... the space might eventually be better spent with some big ol' buttons and informative content about accounts /+ transactions