Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable hide account feature for accounts not managed through emerald (ie geth accounts) #405

Closed
whilei opened this issue Dec 8, 2017 · 3 comments

Comments

@whilei
Copy link
Contributor

whilei commented Dec 8, 2017

screen shot 2017-12-08 at 11 30 15

For accounts not managed through the Emerald backend, the hide feature should be disabled (visible, but greyed-out) instead of just absent.

@whilei whilei changed the title what happened to hiding accounts option? can't hide non-emerald-backend accounts Dec 8, 2017
@whilei whilei changed the title can't hide non-emerald-backend accounts disable hide account feature for non-emerald-backend accounts Dec 8, 2017
@whilei whilei changed the title disable hide account feature for non-emerald-backend accounts disable hide account feature for accounts not managed through emerald (ie geth accounts) Dec 8, 2017
@gagarin55
Copy link
Contributor

gagarin55 commented Dec 26, 2017

We disable hide only for non-zero balances, but anyway let's show disabled hide button

gagarin55 added a commit to gagarin55/emerald-wallet that referenced this issue Dec 26, 2017
@splix
Copy link
Member

splix commented Dec 26, 2017

Hide/remove is disabled for accounts with a balance to avoid losing PK for account with money. For ledger it's not an issue, as PK is stored in HW key anyway, just matter of displaying it with other accounts. I think it should be possible to remove Ledger backed accounts

@shanejonas
Copy link
Contributor

shanejonas commented Jun 22, 2018

I don't think we show geth accounts, just ones you've imported yourself, but we are now showing hide in a disabled state in the UI for clarity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants