Skip to content

Commit

Permalink
Remove unused assertEqualSpanInstrumentationInfo (open-telemetry#4310)
Browse files Browse the repository at this point in the history
* Remove assertEqualSpanInstrumentationInfo

* Changelog

* Update CHANGELOG.md

Co-authored-by: Riccardo Magliocchetti <[email protected]>

---------

Co-authored-by: Riccardo Magliocchetti <[email protected]>
Co-authored-by: Leighton Chen <[email protected]>
  • Loading branch information
3 people authored Nov 26, 2024
1 parent 78653ef commit 2ddb076
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
([#4311](https://github.com/open-telemetry/opentelemetry-python/pull/4311))
- sdk: fix serialization of logs severity_number field to int
([#4324](https://github.com/open-telemetry/opentelemetry-python/pull/4324))
- Remove `TestBase.assertEqualSpanInstrumentationInfo` method, use `assertEqualSpanInstrumentationScope` instead
([#4310](https://github.com/open-telemetry/opentelemetry-python/pull/4310))

## Version 1.28.0/0.49b0 (2024-11-05)

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -70,10 +70,6 @@ def get_finished_spans(self):
self, self.memory_exporter.get_finished_spans()
)

def assertEqualSpanInstrumentationInfo(self, span, module):
self.assertEqual(span.instrumentation_info.name, module.__name__)
self.assertEqual(span.instrumentation_info.version, module.__version__)

def assertEqualSpanInstrumentationScope(self, span, module):
self.assertEqual(span.instrumentation_scope.name, module.__name__)
self.assertEqual(
Expand Down

0 comments on commit 2ddb076

Please sign in to comment.