Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release Pipeline TEST #8

Closed
wants to merge 2 commits into from
Closed

Release Pipeline TEST #8

wants to merge 2 commits into from

Conversation

Scienfitz
Copy link
Collaborator

@Scienfitz Scienfitz commented Nov 29, 2023

please accept this PR to integrate a draft for the release pipeline.

It will be finalized later as there are several things that could not be tested in private repo

QUESTION:
When should the action be triggered? Mu current plan is to trigger

  1. on tag, publish to test-PyPI
  2. on actual release, publish to PyPI / Conda
    This would for instance enable us to only trigger 2 if 1 was performed correctly + baybe can be installed from -testPyPI + the tests run, something that imo makes sense, but I haven't seen anywhere else

Thats all not fully implemented yet, we need to decide that at some point. This merge is to make sure I can at least thst the triggers (which so far havent worked int he private repo)

@CLAassistant
Copy link

CLAassistant commented Nov 29, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@AVHopp AVHopp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you claim that there will be changes involving this pipeline and that we should please simply, I accepted this WITHOUT ACTUALLY REVIEWING. If an actual review is required, please re-request.

Copy link
Collaborator

@AdrianSosic AdrianSosic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Scienfitz. Accepting to unblock you, but now that the repo is public, is this workflow still required? Also, going via a fork seems perhaps the more elegant way for such tests. I did that for the io-pages and that turned out to work quite nicely.

Regarding your suggested triggers: let's perhaps discuss this in a meeting?

@Scienfitz
Copy link
Collaborator Author

Scienfitz commented Dec 1, 2023

Hi @Scienfitz. Accepting to unblock you, but now that the repo is public, is this workflow still required? Also, going via a fork seems perhaps the more elegant way for such tests. I did that for the io-pages and that turned out to work quite nicely.

Regarding your suggested triggers: let's perhaps discuss this in a meeting?

@AdrianSosic i think this workflow is required as its supposed to become the publish action. But if you tell em the fork way is the way to test it then I will probably abandon this PR and go via that?

@Scienfitz Scienfitz closed this Dec 1, 2023
@Scienfitz Scienfitz deleted the repo/release_pipeline branch December 1, 2023 11:24
@AdrianSosic AdrianSosic added the repo Requires changes to the project configuration label Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
repo Requires changes to the project configuration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants