Fix dtype in continuous comp rep #415
Merged
+10
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AVHopp
added
bug
AVHopp
commented
Oct 30, 2024
Scienfitz
reviewed
Oct 31, 2024
AVHopp
commented
Nov 4, 2024
AdrianSosic
reviewed
Nov 5, 2024
Scienfitz
requested changes
Nov 6, 2024
AVHopp
force-pushed
the
fix/dtype_continuous_comp_rep
branch
from
c716922
to
8dae590
Compare
Scienfitz
approved these changes
Nov 7, 2024
AVHopp
force-pushed
the
fix/dtype_continuous_comp_rep
branch
from
8dae590
to
a25196c
Compare
|
@AdrianSosic awaiting your approval/review |
AVHopp
force-pushed
the
fix/dtype_continuous_comp_rep
branch
from
a25196c
to
fdc55e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the DType used when calculating the computational representation in a continuous space.
Currently, the dtype is not using any of our flags but infers it from the provided data, always yielding a
float64representation. This causes troubles down the line, specifically for continuous constraints: These then turn out to have bounds infloat64while other parts are infloat32, making them unusable.