-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Explanation of some Utilities to User Guide #392
Conversation
501662b
to
74c34d1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Scienfitz, thanks for writing. I'll push one more suggestion to generalize the section on effective search space creation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect, thanks for incorporating the changes 🥇
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mucho like, just some minor comments. Feel free to resolve how you see fit.
Co-authored-by: AdrianSosic <[email protected]>
Adds explanations for these utilities:
Note: This required some adjustment of the code execution test. It seems that list comprehensions called via
exec
have some weird scope, causingNameError
forNumericalDiscreteParameter
even though it was imported int he code block. So I am now providing a custom dict as globals and locals arg toexec
which seems to unify the scopes. As far as I know this should still maintain isolation between separately tested code blocks.