Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Continuous Optimization Controls to BotorchRecommender #389

Merged
merged 8 commits into from
Oct 11, 2024

Conversation

Scienfitz
Copy link
Collaborator

@Scienfitz Scienfitz commented Oct 2, 2024

BotorchRecommender now has the optional keywords n_restarts and n_raw_samples which control continuous optimization behavior and can be increased if the user desires. The defaults have been slighlty increased as well as previous values seemed extremely low.

@Scienfitz Scienfitz added the enhancement Expand / change existing functionality label Oct 2, 2024
@Scienfitz Scienfitz self-assigned this Oct 2, 2024
Copy link
Collaborator

@AdrianSosic AdrianSosic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Scienfitz, thx! Here my comments

docs/userguide/recommenders.md Outdated Show resolved Hide resolved
docs/userguide/recommenders.md Outdated Show resolved Hide resolved
baybe/recommenders/pure/bayesian/botorch.py Outdated Show resolved Hide resolved
baybe/recommenders/pure/bayesian/botorch.py Outdated Show resolved Hide resolved
baybe/recommenders/pure/bayesian/botorch.py Outdated Show resolved Hide resolved
@Scienfitz Scienfitz force-pushed the feature/botorch_optimizer_configurability branch from a3b5dd7 to 250a497 Compare October 9, 2024 14:04
@Scienfitz Scienfitz force-pushed the feature/botorch_optimizer_configurability branch from 250a497 to 7f7b677 Compare October 9, 2024 15:21
baybe/recommenders/pure/bayesian/botorch.py Show resolved Hide resolved
baybe/recommenders/pure/bayesian/botorch.py Outdated Show resolved Hide resolved
baybe/recommenders/pure/bayesian/botorch.py Outdated Show resolved Hide resolved
docs/userguide/recommenders.md Outdated Show resolved Hide resolved
@Scienfitz Scienfitz merged commit 573664b into main Oct 11, 2024
11 checks passed
@Scienfitz Scienfitz deleted the feature/botorch_optimizer_configurability branch October 11, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Expand / change existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants