Give up processing and throw ConfigException when "Auth fail" appears at the first time #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… at the first time
tvhung83
reviewed
Oct 5, 2018
| @@ -264,6 +264,12 @@ else if (files.isFile()) { | |||
| @Override | |||
| public boolean isRetryableException(Exception exception) | |||
| { | |||
| if (exception.getCause() != null && exception.getCause().getCause() != null) { | |||
| Throwable cause = exception.getCause().getCause(); | |||
| if (cause.getMessage().contains("Auth fail")) { | |||
There was a problem hiding this comment.
It'd be nice to have a small test to make sure no retry for 'Auth fail' :)
There was a problem hiding this comment.
Added a test to make sure ConfigException is thrown.
To check no retry might be a bit difficult.
tvhung83
reviewed
Oct 5, 2018
| @@ -266,7 +266,7 @@ public boolean isRetryableException(Exception exception) | |||
| { | |||
| if (exception.getCause() != null && exception.getCause().getCause() != null) { | |||
| Throwable cause = exception.getCause().getCause(); | |||
| if (cause.getMessage().contains("Auth fail")) { | |||
| if (!cause.getMessage().isEmpty() && cause.getMessage().contains("Auth fail")) { | |||
There was a problem hiding this comment.
Sorry for confusion 🙇
What I mean is some exceptions won't have message, for example: java.util.concurrent.TimeoutException. So this line still could raise NPE.
tvhung83
approved these changes
Oct 5, 2018
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up for #29
I had improved retry logic while getting file list before #29
Plugin will throw ConfigException when "Auth fail" happens after several retries.
I thought this plugin was a bit unstable, so it's better to retry even if exception is "Auth fail".
However, I found that some external services detect such retry as a invalid access from bot.
They add our source IP to IP black list.
I think it's time to give up to retry "Auth fail" when it first appears.
Stacktrace