Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add validation for "host" and "proxy.host" #31

Merged
merged 3 commits into from
Apr 26, 2018
Merged

Add validation for "host" and "proxy.host" #31

merged 3 commits into from
Apr 26, 2018

Conversation

sakama
Copy link
Contributor

@sakama sakama commented Apr 26, 2018 •
edited
Loading

This PR added validation for host and proxy.host. Almost same with embulk/embulk-output-sftp#48
Plugin doesn't check if these values contains empty chars or not.

And also fixed related 2 problems

  • Plugin shows raw password in log when java.net.URISyntaxException is thrown
  • Plugin try to retry ConfigException

@sakama sakama requested a review from trung-huynh April 26, 2018 05:56
trung-huynh
trung-huynh approved these changes Apr 26, 2018
View reviewed changes
Copy link
Contributor

@trung-huynh trung-huynh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sakama sakama merged commit 9bb1c43 into master Apr 26, 2018
@sakama sakama deleted the add-validation-for-host branch April 26, 2018 06:45
@sakama sakama mentioned this pull request May 7, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trung-huynh trung-huynh trung-huynh approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sakama @trung-huynh