Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename GitHub Actions workflow build to check, add explicit strategy and skip unnecessary run in the workflow #261

Merged
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 30 additions & 4 deletions .github/workflows/build.yml → .github/workflows/check.yml
Original file line number Diff line number Diff line change
@@ -1,10 +1,13 @@
name: Build and test
on: [push, pull_request]
name: Check
on: [ pull_request, push ]
jobs:
mysql5_7:
runs-on: ubuntu-latest
# push: always run.
# pull_request: run only when the PR is submitted from a forked repository, not within this repository.
if: github.event_name == 'push' || github.event.pull_request.head.repo.full_name != github.repository
strategy:
fail-fast: false
runs-on: ubuntu-latest
services:
mysql:
image: mysql:5.7
Expand Down Expand Up @@ -36,9 +39,12 @@ jobs:
name: mysql5_7
path: embulk-input-mysql/build/reports/tests/test
mysql8_3:
runs-on: ubuntu-latest
# push: always run.
# pull_request: run only when the PR is submitted from a forked repository, not within this repository.
if: github.event_name == 'push' || github.event.pull_request.head.repo.full_name != github.repository
strategy:
fail-fast: false
runs-on: ubuntu-latest
services:
mysql:
# Due to MySQL 8.4 disabled mysql_native_password by default,
Expand Down Expand Up @@ -96,6 +102,11 @@ jobs:
path: embulk-input-mysql/build/reports/tests/test
postgresql9_4:
runs-on: ubuntu-latest
# push: always run.
# pull_request: run only when the PR is submitted from a forked repository, not within this repository.
if: github.event_name == 'push' || github.event.pull_request.head.repo.full_name != github.repository
strategy:
fail-fast: false
services:
postgres:
image: postgres:9.4
Expand Down Expand Up @@ -132,6 +143,11 @@ jobs:
# Use PostgreSQL 13 at this time.
postgresql13:
runs-on: ubuntu-latest
# push: always run.
# pull_request: run only when the PR is submitted from a forked repository, not within this repository.
if: github.event_name == 'push' || github.event.pull_request.head.repo.full_name != github.repository
strategy:
fail-fast: false
services:
postgres:
image: postgres:13
Expand Down Expand Up @@ -170,6 +186,11 @@ jobs:
path: embulk-input-postgresql/build/reports/tests/test
redshift:
runs-on: ubuntu-latest
# push: always run.
# pull_request: run only when the PR is submitted from a forked repository, not within this repository.
if: github.event_name == 'push' || github.event.pull_request.head.repo.full_name != github.repository
strategy:
fail-fast: false
# Testing embulk-input-redshift emulated with PostgreSQL.
services:
postgres:
Expand Down Expand Up @@ -205,6 +226,11 @@ jobs:
path: embulk-input-redshift/build/reports/tests/test
sqlserver: # https://hub.docker.com/_/microsoft-mssql-server
runs-on: ubuntu-latest
# push: always run.
# pull_request: run only when the PR is submitted from a forked repository, not within this repository.
if: github.event_name == 'push' || github.event.pull_request.head.repo.full_name != github.repository
strategy:
fail-fast: false
services:
sqlserver:
# To run locallly:
Expand Down