-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Robustly discover packages with @manypkg #47
Conversation
Update release-plan for embroider-build/release-plan#47
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed in the tooling meeting: we should add some basic tests here before proceeding
done -- I added two tests for some scenarios that I'm most immediately concerned with. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! thanks
edit: i forgot that we are pre-1.0 so actually an "enchancement" is really a bugfix 😭 maybe this is something that we should codify in release-plan |
Setup release-plan -- Requires embroider-build/release-plan#47
Resolves: #46
Requires: embroider-build/github-changelog#8 (included in this PR, as it is one half of the solution to #46)
Can test on your own repo with an override:
Additionally, this should unlock the ability to remove
--singlePackage
, as@manypkg
just works.