Set MiniCssExtractPlugin ignoreOrder to true for default config #2219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What other steps need to be done in this PR (for versioning or other tasks)? I did not see further references in the contributing doc |
NullVoxPopuli
approved these changes
Dec 20, 2024
There was a problem hiding this comment.
Makes sense to me
For others, here are the docs on the option:
https://webpack.js.org/plugins/mini-css-extract-plugin/#remove-order-warnings
|
This should target |
|
Closing in favor of #2220 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From this discussion in the Ember Discord: https://discord.com/channels/480462759797063690/1308128146058514474/1319687395024830507 with @ef4
The warnings don't particularly mean much when handling CSS via modules, so it should be safe to make the base config ignore them.