Fix gjs/gts sourcemaps -- we accidentally unlocked really good DX #2166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ource-map (it's not what anyone wants anyway)
Closed
NullVoxPopuli
commented
Nov 8, 2024
| @@ -59,8 +59,8 @@ export class Addon { | |||
| return hbs(options); | |||
| } | |||
|
|
|||
| gjs(options?: { inline_source_map: boolean }) { | |||
There was a problem hiding this comment.
removing this makes this PR a breaking change... but inline source map is likely never something anyone wants as it hasn't been compatible with rollup.
So... this PR "could" be a bugfix, I suppose.
There was a problem hiding this comment.
@NullVoxPopuli IMO it's change in public API - so it's a breaking change regardless if ppl prefer/use inline source maps or not
There was a problem hiding this comment.
@SergeAstapov agreed, and integers are cheap 👍
SergeAstapov
approved these changes
Nov 10, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to:
(and see here for context)
Requires
I will need to upgrade content-tag in this (Fix gjs/gts sourcemaps -- we accidentally unlocked really good DX #2166) PR once released
Something that is quite surprising (in a good way), is that we can inspect live values in templates (which makes sense, and really shows the power of the content-tag strategy we're using.
For example:
