Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix missing vite build assets #2163

Merged
merged 2 commits into from
Dec 10, 2024
Merged

fix missing vite build assets #2163

merged 2 commits into from
Dec 10, 2024

Conversation

patricklx
Copy link
Contributor

@patricklx patricklx commented Nov 5, 2024 •
edited
Loading

No description provided.

mansona
mansona approved these changes Nov 5, 2024
View reviewed changes
Copy link
Member

@mansona mansona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@patricklx patricklx closed this Dec 10, 2024
@patricklx patricklx reopened this Dec 10, 2024
@ef4 ef4 merged commit 78dd1bb into embroider-build:main Dec 10, 2024
210 of 211 checks passed
@github-actions github-actions bot mentioned this pull request Dec 10, 2024
Open
@mansona mansona added the bug Something isn't working label Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mansona mansona mansona approved these changes

@ef4 ef4 ef4 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@patricklx @ef4 @mansona