Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vite hbs plugin should return resolutions #2143

Merged
merged 2 commits into from
Oct 9, 2024
Merged

Vite hbs plugin should return resolutions #2143

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7b68bdf
Vite hbs plugin should return resolutions
ef4 Oct 8, 2024
d497306
restoring an hbs fallback case that was actually needed
ef4 Oct 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/vite/src/hbs.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,9 @@ export function hbs(): Plugin {
});

if (!resolution) {
// vite already has extension search fallback for extensionless imports.
// This is different, it covers an explicit .js import fallback to the
// corresponding hbs.
let hbsSource = syntheticJStoHBS(source);
if (hbsSource) {
resolution = await this.resolve(hbsSource, importer, {
Expand Down Expand Up @@ -70,6 +73,8 @@ export function hbs(): Plugin {
},
};
}

return resolution;
},

load(id: string) {
Expand Down