-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update release-deps #2070
base: main
Are you sure you want to change the base?
Update release-deps #2070
Conversation
Something seems convinced that
OR maybe I'm reading it wrong, and it's saying that "a module" is a v1 addon, and that v1 addon needs auto-import. ah-ha! running with vite reveals that the problem comes from ember-data:
Here is the package.json for here{
"name": "@ember-data/serializer",
"version": "5.3.0",
"description": "Provides Legacy JSON, JSON:API and REST Implementations of the Serializer Interface for use with @ember-data/store",
"keywords": [
"ember-addon"
],
"repository": {
"type": "git",
"url": "git+ssh://[email protected]:emberjs/data.git",
"directory": "packages/serializer"
},
"license": "MIT",
"author": "",
"directories": {},
"ember-addon": {
"main": "addon-main.js",
"type": "addon",
"version": 1
},
"files": [
"blueprints",
"addon-main.js",
"addon",
"README.md",
"LICENSE.md",
"ember-data-logo-dark.svg",
"ember-data-logo-light.svg"
],
"peerDependencies": {
"@ember/string": "^3.1.1",
"ember-inflector": "^4.0.2"
},
"dependenciesMeta": {
"@ember-data/private-build-infra": {
"injected": true
},
"@ember/string": {
"injected": true
}
},
"dependencies": {
"@ember-data/private-build-infra": "5.3.0",
"@embroider/macros": "^1.13.1",
"ember-cli-babel": "^8.0.0",
"ember-cli-test-info": "^1.0.0"
},
"devDependencies": {
"@babel/cli": "^7.22.15",
"@babel/core": "^7.22.19",
"@babel/plugin-proposal-decorators": "^7.22.15",
"@babel/plugin-transform-class-properties": "^7.22.5",
"@babel/plugin-transform-private-methods": "^7.22.5",
"@babel/plugin-transform-runtime": "^7.22.15",
"@babel/plugin-transform-typescript": "^7.22.15",
"@babel/preset-env": "^7.22.15",
"@babel/preset-typescript": "^7.22.15",
"@babel/runtime": "^7.22.15",
"@ember-data/store": "5.3.0",
"@embroider/addon-dev": "^4.1.0",
"@glimmer/component": "^1.1.2",
"@rollup/plugin-babel": "^6.0.3",
"@rollup/plugin-node-resolve": "^15.2.1",
"ember-source": "~5.2.0",
"rollup": "^3.29.1",
"tslib": "^2.6.2",
"typescript": "^5.2.2",
"walk-sync": "^3.0.0",
"webpack": "^5.88.2"
},
"engines": {
"node": "16.* || >= 18.*"
},
"volta": {
"extends": "../../package.json"
},
"packageManager": "[email protected]",
"scripts": {
"build": "rollup --config && babel ./addon --out-dir addon --plugins=../private-build-infra/src/transforms/babel-plugin-transform-ext.js",
"start": "rollup --config --watch"
}
} This is a v1 addon, and there is no ember-auto-import.. Now, this is only an issue when an app tries to use Ideally, I would think we allow a duplicate to occur, and have ember-data use For ember-data, specifically, it appears that 5.4 (currently alpha) is a v2 addon, https://github.com/emberjs/data/blob/main/packages/serializer/package.json#L25 (and they dropped But updating to newer ember-data would work around the problem. There are some PRs to widen the range of
But they'd probably need to be backported to 5.3 and 4.12 -- which means that any package that depends on |
No description provided.