Move rewritten app to ./tmp #1985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're very close to eliminating the rewritten app, but vite's extremely loose `inNodeModules` behavior is breaking features that we need to use to actually get there. So we're moving the rewritten-app from `./node_modules/.embroider` to `./tmp`, since this path stops confusing vite. The immediate motivation here was to get inline script tags working in index.html. If your index.html has the string `node_modules` anywhere in its path that vite feature breaks.
because it handles the weirdness of dummy apps
|
Filed vite bug for the issue this PR works around: vitejs/vite#17467 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're very close to eliminating the rewritten app, but vite's extremely loose
inNodeModulesbehavior is breaking features that we need to use to actually get there. So we're moving the rewritten-app from./node_modules/.embroiderto./tmp, since this path stops confusing vite.The immediate motivation here was to get inline script tags working in index.html. If your index.html has the string
node_modulesanywhere in its path that vite feature breaks.