New index.html- format test-entrypoint
#1926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BlueCutOfficial
changed the title
index.html- format test entrypointindex.html- format test-entrypoint
mansona
force-pushed
the
new-index-html-format-test-entrypoint
branch
from
0ed4657 to
1f8b749
Compare
mansona
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Lately, we have been working on the inversion of control for the Vite build, we replaced script assets like
vendor.jswith virtual content Vite can request to Embroider.Until now, we have never changed the
index.htmlfile of the initial Ember app to handle virtualization: in stage 2, the compat-app-builder generates theindex.htmlof the rewritten-app and inserts the virtual entry points. This rewritten file is the one consumed by Vite.Now that we have virtualized all the entry points, we are ready for the next step that will get us closer to the new blueprint: we are going to write the virtual entry points directly in the
index.htmlof the initial Ember app so Vite will be able to consume it directly, without intermediate change.This PR handles the
test-entrypoint.