virtualise test entrypoint #1924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mansona
force-pushed
the
virtual-test-entrypoint
branch
2 times, most recently
from
9f6a400 to
77ee831
Compare
ef4
reviewed
May 16, 2024
There was a problem hiding this comment.
I think this either needs to be radically reduced down to things that only happen in the tests entrypoint or (if we really do need a lot of this code) needs to share the implementation with the app entrypoint. I don't want to just duplicate the implementation.
BlueCutOfficial
force-pushed
the
virtual-test-entrypoint
branch
from
0ed4657 to
77ee831
Compare
mansona
force-pushed
the
virtual-test-entrypoint
branch
from
77ee831 to
b811064
Compare
mansona
force-pushed
the
virtual-test-entrypoint
branch
from
b811064 to
244ab55
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.