Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New index.html format - entrypoint #1922

Merged
merged 3 commits into from
May 16, 2024
Merged

New index.html format - entrypoint #1922

merged 3 commits into from
May 16, 2024

Conversation

BlueCutOfficial
Copy link
Collaborator

@BlueCutOfficial BlueCutOfficial commented May 16, 2024

Context

Lately, we have been working on the inversion of control for the Vite build, we replaced script assets like vendor.js with virtual content Vite can request to Embroider.

Until now, we have never changed the index.html file of the initial Ember app to handle virtualization: in stage 2, the compat-app-builder generates the index.html of the rewritten-app and inserts the virtual entry points. This rewritten file is the one consumed by Vite.

Now that we have virtualized all the entry points, we are ready for the next step that will get us closer to the new blueprint: we are going to write the virtual entry points directly in the index.html of the initial Ember app so Vite will be able to consume it directly, without intermediate change.

This PR handles entrypoint.

@BlueCutOfficial BlueCutOfficial changed the title New index html format app New index.html format - entrypoint May 16, 2024
@BlueCutOfficial BlueCutOfficial force-pushed the new-index-html-format-app branch from 95be548 to bba11c5 Compare May 16, 2024 14:01
@BlueCutOfficial BlueCutOfficial added the enhancement New feature or request label May 16, 2024
@BlueCutOfficial BlueCutOfficial force-pushed the new-index-html-format-app branch from bba11c5 to be5f83e Compare May 16, 2024 14:04
@BlueCutOfficial BlueCutOfficial marked this pull request as ready for review May 16, 2024 15:20
Copy link
Member

@mansona mansona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! 🎉 :shipit:

@mansona mansona merged commit 14b84ff into main May 16, 2024
176 checks passed
@mansona mansona deleted the new-index-html-format-app branch May 16, 2024 15:33
@github-actions github-actions bot mentioned this pull request May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants