virtualise engine styles with their vendor styles #1913
Conversation
mansona
force-pushed
the
virtual-compat-styles
branch
from
644e72e to
0360a74
Compare
| let result: string[] = impliedAddonVendorStyles(engine).map((sourcePath: string): string => { | ||
| let source = readFileSync(sourcePath); | ||
| return `${source}`; | ||
| }); | ||
|
|
||
| // add engine's own implicit styles after all vendor styles | ||
| let styles = getAddonImplicitStyles(engine.package as V2AddonPackage); |
There was a problem hiding this comment.
This is not what I had in mind. Consider the app: the app never has implicit styles, but it does have it's own styles (the stuff from app/styles/app.css). That's the stuff we're talking about incorporating here.
There was a problem hiding this comment.
yes but during the v2 upgrade of an app don't their styles get applied to the engine's implicit styles? I would have expected a lot more tests to fail in this PR if the approach didn't work 🤔
There was a problem hiding this comment.
I guess not 🙈 it turns out that the only test that checks for the app scripts right now is the namespaced app that has a qunit test Acceptance | smoke-test: styles present 🫠
I'll take another look at it
There was a problem hiding this comment.
So I've implemented this now in such a way that it goes to find the right file out of the @embroider/synthesized-styles package and read its contents, but I'm wondering if we need to even generate a synthesised styles package any more 🤔
Looking at where it is generated https://github.com/embroider-build/embroider/blob/virtual-compat-styles/packages/compat/src/compat-app.ts#L505-L539 it seems to imply that there can be multiple files output other than just the app-name.css even though only one of the files was ever being consumed by the rewritten app. Am I missing some context here as to why it was written this way?
mansona
changed the title
mansona
force-pushed
the
virtual-compat-styles
branch
3 times, most recently
from
5b0aef2 to
97d4334
Compare
mansona
force-pushed
the
virtual-compat-styles
branch
from
97d4334 to
0a5d27b
Compare
mansona
force-pushed
the
virtual-compat-styles
branch
from
0a5d27b to
0892a3a
Compare
|
I have now verified that this is working with the latest HEAD of #1779 👍 |
For #1779 it would be a lot easier for the implementation of an engine's own styles to be handled with the same virtual handler that deals with its vendor files. This PR makes that change 👍