Command Watcher #1877
Command Watcher #1877
Conversation
… dev mode,use a vite build for the build mode test
| @@ -81,6 +82,7 @@ | |||
| "ember-source-latest": "npm:ember-source@latest", | |||
| "ember-truth-helpers": "^3.0.0", | |||
| "execa": "^5.1.1", | |||
| "node-fetch": "2.7.0", | |||
There was a problem hiding this comment.
I had to use [email protected] because > 3.x is an ESM-only package. Importing this into the scenarios files triggers an Unknown file extension ".ts" error.
BlueCutOfficial
force-pushed
the
command-watcher
branch
from
79052a8 to
71fe283
Compare
BlueCutOfficial
force-pushed
the
command-watcher
branch
from
71fe283 to
107da9b
Compare
| @@ -81,6 +82,8 @@ | |||
| "ember-source-latest": "npm:ember-source@latest", | |||
| "ember-truth-helpers": "^3.0.0", | |||
| "execa": "^5.1.1", | |||
| "node-fetch": "2.7.0", | |||
| "strip-ansi": "^6.0.0", | |||
There was a problem hiding this comment.
I had to use [email protected] because > 7.x is an ESM-only package. Importing this into the scenarios files triggers an Unknown file extension ".ts" error or an ERR_REQUIRE_ESM error.
… assets plugin to the addon template
… flexible regexp to wait for the server and call strip-ansi because vite output contains colors messing up with theregexp
…don to make sure the publicDir config doesn't interfeer with addons
BlueCutOfficial
force-pushed
the
command-watcher
branch
from
c651a11 to
9639001
Compare
| public: { | ||
| 'from-addon.txt': 'a public asset provided by the classic addon', | ||
| }, |
There was a problem hiding this comment.
Maybe overkill but I added a public asset at the root to show that changing the publicDir location (that allows the public assets of the dummy app to be copied in the dist) does not impact how the addon's public assets are served and added to the dist by the assets plugin.
| assets.includes('./addon-template/from-addon.txt'); | ||
| }); | ||
|
|
||
| test('production build contains public assets from both addon and dummy app after a build', async function (assert) { |
There was a problem hiding this comment.
This test builds the dummy app the same way as the one checking the rewritten-app so I could have done all the checks in the same test. I preferred separated tests because I want to remove the rewritten-app one in PR #1859
mansona
added
enhancement
Context
When working with vite, running the dev server and generating the production build with Rollup are two different actions that both have a specific execution. For instance, when dealing with public assets provided by the app and addons:
assetsplugin uses a middleware to catch the assets-related request, find the actual location of the asset, and serve it.assetsplugin will emit the public assets in thedist/output, where they are supposed to be.This case highlights why we need to test some behaviors for both dev mode and build mode now the test suite is using vite.
Testing dev mode easily
This PR implements a
CommandWatcherutility to ease running a vite dev server in tests. It relies on the formerEmberCLIclass that was used to runember serve, but it makes it more generic (you can now choose the name of the command likeemberorvite) and it makes it an importable helper so we can test the dev mode in multiple test files.Compat dummy app test
The first use case for the new
CommandWatcheris thecompat-dummy-app-test. This PR prepares the field so the tests that check public assets presence now use vite and check both the dev mode and the build.This preparation work is required to complete #1859, which will remove the part of the code that is now managed by the
assetsplugin: in #1859,compat-dummy-app-testwill have to stop testing public assets are present in the rewritten app and instead test they are present in thedist(in build mode) or served correctly (in dev mode).Here, aside of the assertions, we do the following things:
assetsplugin and we also updateember-qunitto fix an issue in the development build.CommandWatcherimplementation, we strip the Ansi characters before analyzing the server output, because vite server colorize the text, which can mess-up the regex.