support import sync with dynamic expression #1845
Conversation
|
e.g. ember-svg-jar |
|
The screenshot shows keys with extension. That is fixed. |
|
Thanks, the output of this transformation looks great. Please remove the BinaryExpression support. It's not always correct (people can use operators other than |
|
@ef4 i removed the binary expression support |
| relativePath = specifier.quasis[0].value.cooked!; | ||
| property = specifier.expressions[0]; | ||
| } | ||
| // babel might transform template form `../my-path/${id}` to '../my-path/'.concat(id) |
There was a problem hiding this comment.
I didn't notice before that this stuff is distinct from the BinaryExpression support. I don't think it's correct.
Consider:
importSync(`one${two}three${four}`)
// becomes
importSync("one".concat(two, "three").concat(four));(It would be even better to figure out how to run before preset-env, but I recognize that this is already in an exit hook because it's trying to interoperate with other plugins that adjust the import specifiers themselves.)
There was a problem hiding this comment.
Right, i only support "one".concat. this is done by ensuring that the object of the member expression is a string.
one${two}three${four} is also not supported
No description provided.