Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge stable into main #1782

Merged
merged 20 commits into from
Feb 1, 2024
Merged

Merge stable into main #1782

merged 20 commits into from
Feb 1, 2024

Conversation

mansona
Copy link
Member

@mansona mansona commented Feb 1, 2024

No description provided.

github-actions[bot] and others added 20 commits December 13, 2023 18:51
I'm working on a cleanup in ember-cli-htmlbars that is blocked on embroider touching some internals.
It's not possible to have more than one colocated template for a given JS file, so we never need to run again.

Fixes ef4/decorator-transforms#16
Make template-colocation-plugin idempotent
When ownerOfFile gets to the root of the filesystem it ends up trying to check the path `''` which then goes through realpathSync and becomes the current working directory. This causes any unowned file to incorrectly get attributed to the app.
Seems some dependency version update caused the compilation output to change slightly, making our (brittle!) test fail.
Fix incorrect ownerOfFile at root of filesystem
@mansona mansona merged commit 2f2d9f8 into main Feb 1, 2024
93 checks passed
@mansona mansona deleted the merge-stable branch February 1, 2024 13:38
@github-actions github-actions bot mentioned this pull request Feb 5, 2024
@github-actions github-actions bot mentioned this pull request Apr 4, 2024
@github-actions github-actions bot mentioned this pull request Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants