-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge stable into main #1782
Merged
Merged
Merge stable into main #1782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prepare Release
fix publish for stable branch
I'm working on a cleanup in ember-cli-htmlbars that is blocked on embroider touching some internals.
Don't rely on htmlbars internals
Prepare Release
It's not possible to have more than one colocated template for a given JS file, so we never need to run again. Fixes ef4/decorator-transforms#16
Make template-colocation-plugin idempotent
When ownerOfFile gets to the root of the filesystem it ends up trying to check the path `''` which then goes through realpathSync and becomes the current working directory. This causes any unowned file to incorrectly get attributed to the app.
Seems some dependency version update caused the compilation output to change slightly, making our (brittle!) test fail.
Fix failing addon-dev-js test on stable
Fix incorrect ownerOfFile at root of filesystem
# Conflicts: # pnpm-lock.yaml
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.