Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify vite-app template #1771

Merged
merged 1 commit into from
Jan 25, 2024
Merged

Simplify vite-app template #1771

merged 1 commit into from
Jan 25, 2024

Conversation

ef4
Copy link
Contributor

@ef4 ef4 commented Jan 25, 2024

Move ember-data into the specific test scenario thats wants it, so that the base vite-app template does't need to have ember-data.

Move ember-data into the specific test scenario thats wants it, so that the base vite-app template does't need to have ember-data.
@ef4 ef4 added the internal label Jan 25, 2024
Copy link
Member

@mansona mansona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🎉

@ef4 ef4 merged commit 2287af7 into main Jan 25, 2024
95 checks passed
@ef4 ef4 deleted the simplify-vite-app-template branch January 25, 2024 13:47
@github-actions github-actions bot mentioned this pull request Jan 25, 2024
@github-actions github-actions bot mentioned this pull request Apr 4, 2024
@github-actions github-actions bot mentioned this pull request Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants