Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update scenario-tester #1714

Merged
merged 2 commits into from
Jan 4, 2024
Merged

update scenario-tester #1714

merged 2 commits into from
Jan 4, 2024

Conversation

mansona
Copy link
Member

@mansona mansona commented Dec 7, 2023

I'm not exactly sure why typescript can't find the types from the new version of scenario-tester 🤔 anyone have any clues?

Thanks to @SergeAstapov we found the issue with types. And thanks to @ef4 we fixed the upstream issue and got [email protected] released 🎉

@SergeAstapov
Copy link
Collaborator

@mansona maybe you need to add typesVersions to package.json with smth like

"typesVersions": {
    "*": {
      "*": [
        "dist/*"
      ]
    }
  },

@mansona
Copy link
Member Author

mansona commented Dec 7, 2023

Yep that did it 🎉 thanks @SergeAstapov

@mansona mansona force-pushed the update-scenario-tester branch from fa0c98c to 4144d34 Compare January 4, 2024 14:35
@mansona mansona force-pushed the update-scenario-tester branch from 4144d34 to 4b3b530 Compare January 4, 2024 14:37
@mansona mansona marked this pull request as ready for review January 4, 2024 14:38
@mansona mansona merged commit a74ae69 into main Jan 4, 2024
205 checks passed
@mansona mansona deleted the update-scenario-tester branch January 4, 2024 15:26
@github-actions github-actions bot mentioned this pull request Jan 4, 2024
@github-actions github-actions bot mentioned this pull request Apr 4, 2024
@github-actions github-actions bot mentioned this pull request Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants