Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create new @embroider/reverse-exports package #1652

Merged
merged 4 commits into from
Nov 20, 2023
Merged

Conversation

lolmaus
Copy link
Collaborator

@lolmaus lolmaus commented Oct 30, 2023

Copy link
Member

@mansona mansona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good so far 🎉 we need to add the conditional exports stuff (at least for import, export, and default) and then "just" add the implementation 😂

packages/reverse-exports/tests/reverse-exports.test.ts Outdated Show resolved Hide resolved
packages/reverse-exports/tests/reverse-exports.test.ts Outdated Show resolved Hide resolved
packages/reverse-exports/tests/reverse-exports.test.ts Outdated Show resolved Hide resolved
packages/reverse-exports/tests/reverse-exports.test.ts Outdated Show resolved Hide resolved
packages/reverse-exports/tests/reverse-exports.test.ts Outdated Show resolved Hide resolved
packages/reverse-exports/tests/reverse-exports.test.ts Outdated Show resolved Hide resolved
@lolmaus lolmaus force-pushed the feature-reverse-exports branch from f0383b6 to 1050157 Compare November 13, 2023 15:22
packages/reverse-exports/src/index.ts Outdated Show resolved Hide resolved
packages/reverse-exports/tests/reverse-exports.test.ts Outdated Show resolved Hide resolved
@mansona
Copy link
Member

mansona commented Nov 16, 2023

as for the case where we have an exports but don't match it correctly, I think we should throw with an error like:

You tried to reverse exports for the file <filename> in package <package name> but it does not match any of the packages exports rules. This means it should not be possible to access directly.

@lolmaus
Copy link
Collaborator Author

lolmaus commented Nov 17, 2023

as for the case where we have an exports but don't match it correctly, I think we should throw with an error like:

Done.

@lolmaus lolmaus requested a review from mansona November 17, 2023 15:54
@lolmaus lolmaus marked this pull request as ready for review November 20, 2023 09:49
@mansona mansona changed the title reverse-exports package create new @embroider/reverse-exports package Nov 20, 2023
@mansona mansona added the enhancement New feature or request label Nov 20, 2023
@mansona mansona force-pushed the feature-reverse-exports branch from ddb2dfe to af0a18b Compare November 20, 2023 14:41
Copy link
Member

@mansona mansona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🎉

@mansona mansona merged commit 9606cac into main Nov 20, 2023
204 checks passed
@mansona mansona deleted the feature-reverse-exports branch November 20, 2023 15:04
@github-actions github-actions bot mentioned this pull request Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants