-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
create new @embroider/reverse-exports package #1652
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good so far 🎉 we need to add the conditional exports stuff (at least for import, export, and default) and then "just" add the implementation 😂
f0383b6
to
1050157
Compare
as for the case where we have an exports but don't match it correctly, I think we should throw with an error like:
|
Done. |
ddb2dfe
to
af0a18b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 🎉
Some references: