performance: avoid paying decodeFastbootSwitch regex cost unless needed #1611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ef4
reviewed
Sep 26, 2023
|
Sure, I can add those to this PR |
raycohen
force-pushed
the
perf-run-regex-on-fewer-files-in-decodeFastbootSwitch
branch
from
404b014 to
2d08d0c
Compare
…th filename includes check
void-mAlex
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #1610
Before this change, my large app was spending 20+ seconds on the regex:
After this change, it spends no time here (my app does not use fastboot, so the condition is never met). I think this condition will be correct for users that do use fastboot.