update deprecated (and removed) blacklist config in test app #1469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mansona
changed the title
simonihmig
approved these changes
Jun 13, 2023
There was a problem hiding this comment.
Nice catch! Given this is green, this seems to fix release-stage-1-problematic-addon-zoo failures on master and other feature branches!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that [email protected] has merged ember-cli/ember-cli#10175 which removes the blacklist key for addons and replaces it with
exclude.I have a feeling we might need to use the right one based on a version but I'm trying this PR just updating it for now 👍