WriteV1Config: fix /tests support

[22a]

Addresses #1387 (development config incorrectly loaded instead of test config when visiting /tests with tests: true, storeConfigInMeta: false)

This PR applies the conditional logic suggested in #1387 (comment)

Example module output with `tests: true`

__webpack_require__.r(__webpack_exports__);
/* harmony export */ __webpack_require__.d(__webpack_exports__, {
/* harmony export */   "default": () => (__WEBPACK_DEFAULT_EXPORT__)
/* harmony export */ });
/* harmony import */ var _Users_petermeehan_src_embroider_packages_macros_src_addon_runtime__WEBPACK_IMPORTED_MODULE_0__ = __webpack_require__(/*! ../../../../../../../../Users/petermeehan/src/embroider/packages/macros/src/addon/runtime */ "../../../../../../../../Users/petermeehan/src/embroider/packages/macros/src/addon/runtime.js");

let env;
if ((0,_Users_petermeehan_src_embroider_packages_macros_src_addon_runtime__WEBPACK_IMPORTED_MODULE_0__.isTesting)()) {
 env = {
   "modulePrefix": "with",
   "environment": "test",
   "rootURL": "/",
   "locationType": "none",
   "EmberENV": {
     "FEATURES": {},
     "_APPLICATION_TEMPLATE_WRAPPER": false,
     "_DEFAULT_ASYNC_OBSERVERS": true,
     "_JQUERY_INTEGRATION": false,
     "_TEMPLATE_ONLY_GLIMMER_COMPONENTS": true
   },
   "APP": {
     "rootElement": "#ember-testing",
     "LOG_ACTIVE_GENERATION": false,
     "LOG_VIEW_LOOKUPS": false,
     "autoboot": false,
     "name": "with",
     "version": "0.0.0+ab033a51"
   }
 };
} else {
 env = {
   "modulePrefix": "with",
   "environment": "development",
   "rootURL": "/",
   "locationType": "history",
   "EmberENV": {
     "FEATURES": {},
     "_APPLICATION_TEMPLATE_WRAPPER": false,
     "_DEFAULT_ASYNC_OBSERVERS": true,
     "_JQUERY_INTEGRATION": false,
     "_TEMPLATE_ONLY_GLIMMER_COMPONENTS": true
   },
   "APP": {
     "rootElement": ".non-testing-div",
     "name": "with",
     "version": "0.0.0+ab033a51"
   }
 };
}
/* harmony default export */ const __WEBPACK_DEFAULT_EXPORT__ = (env);

//# sourceURL=webpack://with/./config/environment.js?

Example module output with `tests: false`

__webpack_require__.r(__webpack_exports__);
/* harmony export */ __webpack_require__.d(__webpack_exports__, {
/* harmony export */   "default": () => (__WEBPACK_DEFAULT_EXPORT__)
/* harmony export */ });
/* harmony default export */ const __WEBPACK_DEFAULT_EXPORT__ = ({
  "modulePrefix": "with",
  "environment": "development",
  "rootURL": "/",
  "locationType": "history",
  "EmberENV": {
    "FEATURES": {},
    "_APPLICATION_TEMPLATE_WRAPPER": false,
    "_DEFAULT_ASYNC_OBSERVERS": true,
    "_JQUERY_INTEGRATION": false,
    "_TEMPLATE_ONLY_GLIMMER_COMPONENTS": true
  },
  "APP": {
    "rootElement": ".non-testing-div",
    "name": "with",
    "version": "0.0.0+ab033a51"
  }
});

//# sourceURL=webpack://with/./config/environment.js?

Answered questions about the implementation for this.

• Is changing the type signature of WriteV1Config acceptable? Is there a better way to create an instance of V1Config with env hardcoded to test and pass it in?
  • Discussed in office hours. It's fine.
• Could this change negatively impact the behaviour of non test builds?
  • Test suite didn't surface anything and my local testing of tests: true and false shows the expected config being loaded
• Is creating a broccoli plugin with super([inputTree, undefined]) equivalent to super([inputTree])?
  • Answer: Nope
• Is there a good way to add a test for this?
  • Discussed in office hours: Yes, add a scenario. I'm tracking this work here (Add test scenario for tests: true storeConfigInMeta: false config 22a/embroider#1) instead of cluttering this PR with messy attempts to learn the scenario system

[mansona]

Looks good to me 🎉