Add @ember/owner to emberVirtualPackages #1394
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For compatibility, we need to know the full set of virtual package names used by Ember. Historically we got that from the ember-rfc176-data package, but that is no longer updated for new APIs because the modules-api-polyfill that it was created to power is no longer needed. Without this, v2 addons under embroider will fail to resolve these package names.
ef4
added a commit
to ef4/tracked-params
that referenced
this pull request
Apr 10, 2023
|
Looks like this needs rebase (confirmed here) |
|
we merged this work in #1396 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For compatibility, we need to know the full set of virtual package names used by Ember. Historically we got that from the ember-rfc176-data package, but that is no longer updated for new APIs because the modules-api-polyfill that it was created to power is no longer needed.
Without this, v2 addons under embroider will fail to resolve these package names.