Fastboot lazy css support #1140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So that we can use process.env.EMBROIDER_TEST_SETUP_OPTIONS to configure the apps.
This achieves correctness by avoiding use of the MiniCssExtractPlugin runtime inside fastboot. Right now It works by making all the lazy CSS eager. This is strictly better than being broken. Further work can follow to make the lazy chunks actually lazy in fastboot, such that we detect during rendering which ones were wanted and only insert link tags for those ones.
This was here to try to make each filter match an exact module name, but that apparently causes their child modules not to run.
|
This is working as intended, but the test failures are places where we already had tests for lazy CSS in engines that have now been forced to be eager. Next step it to investigate how those were ever working -- it's possible they weren't and the tests simply didn't hit the bad cases. |
They only work without fastboot. They never really worked with fastboot, but we were not running them properly in CI.
|
I confirmed that the lazy engines CSS case was actually broken all along in fastboot, and the test wasn't running properly in CI before. So I'm adjusting the tests to guard that case and only assert that lazy engine CSS is lazy in non-fastboot apps. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a crash that can occur if an app tries to lazily load CSS in fastboot.
This change works by making all the lazy CSS eager. This is strictly better than being broken. Further work can follow to make the lazy chunks actually lazy in fastboot, such that we detect during rendering which ones were wanted and only insert link tags for those ones.
Apps that don't use fastboot should be unaffected.