[Addon Dev] allow all of rollup's OutputOptions to be passed to addon.output() #1104
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update!
This PR adds pass-through support for all of rollup's output options:
Intellisense confirmed working, too:
(old PR description)
I found myself wanting to provide sourcemaps for libraries.
addon.output()
does not allow for that, but you could do:but, that's extra code on the consuming side, when it could just be 1 extra line of config in the
new Addon
part of the rollup config file.There are a lot of output options tho: https://rollupjs.org/guide/en/#outputoptions-object.
🤷
Maybe instead, we can take any object as an argument to
.output()
and merge that in the rollup config?